Skip to content

combined dagger bump#4269

Merged
tobiasKaminsky merged 2 commits into
masterfrom
daggerBump
Jul 29, 2019
Merged

combined dagger bump#4269
tobiasKaminsky merged 2 commits into
masterfrom
daggerBump

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Jul 26, 2019

Copy link
Copy Markdown
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
combined dagger bump
e21f409 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky added 3. to review dependencies Pull requests that update a dependency file labels Jul 26, 2019
@AndyScherzinger

AndyScherzinger commented Jul 26, 2019

Copy link
Copy Markdown
Member

Build is failing ❗️

@tobiasKaminsky

tobiasKaminsky commented Jul 26, 2019

Copy link
Copy Markdown
Member Author

https://github.com/google/dagger/releases/tag/dagger-2.24

@ezaquarii so they removed the individual implementation, but only use HasAndroidInjector now.
But I fail to change this…

@ezaquarii
Migrate main app to new Dagger injector API
976e38e 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@ezaquarii

ezaquarii commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator

@tobiasKaminsky @AndyScherzinger Dagger migration is done.

@AndyScherzinger

AndyScherzinger commented Jul 26, 2019

Copy link
Copy Markdown
Member

I am afk but can give it a spin next week. 👍

@nextcloud-android-bot

nextcloud-android-bot commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10110.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

nextcloud-android-bot commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator

Codacy

281

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings70
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings136
Total423

@codecov

codecov Bot commented Jul 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4269 into master will decrease coverage by 0.54%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4269      +/-   ##
============================================
- Coverage      14.3%   13.76%   -0.55%     
  Complexity        1        1              
============================================
  Files           331      331              
  Lines         31030    31028       -2     
  Branches       4405     4405              
============================================
- Hits           4439     4270     -169     
- Misses        25810    26036     +226     
+ Partials        781      722      -59
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/owncloud/android/MainApp.java 54.41% <100%> (-0.29%) 0 <0> (ø)
...ava/com/owncloud/android/utils/DataHolderUtil.java 58.82% <0%> (-23.53%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 12.21% <0%> (-16.22%) 0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java 47.05% <0%> (-8.83%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java 78.26% <0%> (-4.35%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 28.86% <0%> (-4.23%) 0% <0%> (ø)
...ava/com/owncloud/android/utils/DrawerMenuUtil.java 42.42% <0%> (-3.04%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 47% <0%> (-2.14%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 16.99% <0%> (-1.87%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 62.38% <0%> (-1.84%) 0% <0%> (ø)
... and 7 more

1 similar comment
@codecov

codecov Bot commented Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4269 into master will decrease coverage by 0.54%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4269      +/-   ##
============================================
- Coverage      14.3%   13.76%   -0.55%     
  Complexity        1        1              
============================================
  Files           331      331              
  Lines         31030    31028       -2     
  Branches       4405     4405              
============================================
- Hits           4439     4270     -169     
- Misses        25810    26036     +226     
+ Partials        781      722      -59
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/owncloud/android/MainApp.java 54.41% <100%> (-0.29%) 0 <0> (ø)
...ava/com/owncloud/android/utils/DataHolderUtil.java 58.82% <0%> (-23.53%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 12.21% <0%> (-16.22%) 0% <0%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java 47.05% <0%> (-8.83%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/MimeTypeUtil.java 78.26% <0%> (-4.35%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 28.86% <0%> (-4.23%) 0% <0%> (ø)
...ava/com/owncloud/android/utils/DrawerMenuUtil.java 42.42% <0%> (-3.04%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 47% <0%> (-2.14%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 16.99% <0%> (-1.87%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 62.38% <0%> (-1.84%) 0% <0%> (ø)
... and 7 more

@AndyScherzinger

AndyScherzinger commented Jul 29, 2019

Copy link
Copy Markdown
Member

👍 Works fine for me 👍

@tobiasKaminsky

tobiasKaminsky commented Jul 29, 2019

Copy link
Copy Markdown
Member Author

Tested & works.
@ezaquarii thanks for fixing it. I tried nearly the same, but for an unknown reason it did not worked.

@tobiasKaminsky
tobiasKaminsky merged commit 53a4844 into master Jul 29, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the daggerBump branch July 29, 2019 07:17
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jul 29, 2019
tobiasKaminsky added a commit that referenced this pull request Jul 30, 2019
@tobiasKaminsky
daily dev 20190730
84e3629 
129e9ab Merge pull request #4276 from nextcloud/uploader
bc0b9e7 Engineering Test Mode (#4133)
a6371ee check status on transfer update
0938d81 mHostUrlInput can be null if used with direct login (#4270)
53a4844 Merge pull request #4269 from nextcloud/daggerBump
4632dc6 [tx-robot] updated from transifex
2124364 daily dev 20190727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezaquarii ezaquarii ezaquarii left review comments
@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

No one assigned

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

Nextcloud App 3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @AndyScherzinger @ezaquarii @nextcloud-android-bot